ci-operator/step-registry/ipi/install: Drop TF_LOG from 'create manifests' #8299
Conversation
…ests' No Terraform involved in creating manifests. Cleans up after d11bca7 (create a hybrid cluster and run the e2e tests on it, 2020-04-01, openshift#8075). Also removes trailing whitespace from the YAML documentation. Also backgrounds the 'create manifests' call and immediately waits for it, so we can gracefully handle TERM as described in 4472ace (ci-operator/templates/openshift/installer: Restore backgrounded 'create cluster', 2019-01-23, openshift#2680).
openshift-ci-robot
added
the
approved
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| @@ -35,16 +35,15 @@ cp "${SHARED_DIR}/install-config.yaml" "${dir}/" | |||
| mkdir -p ~/.ssh | |||
| cp "${SSH_PRIV_KEY_PATH}" ~/.ssh/ | |||
|
|
|||
|
|
|||
| TF_LOG=debug openshift-install --dir="${dir}" create manifests | |||
| openshift-install --dir="${dir}" create manifests & | |||
There was a problem hiding this comment.
Is this a change that we should make in all of the places where openshift-install create manifests is called?
$ grep -rnE ./ci-operator/ -e "openshift-install (.* )?create manifests"
./ci-operator/templates/openshift/installer/cluster-launch-installer-ovirt-e2e.yaml:439: TF_LOG=debug openshift-install --dir=/tmp/artifacts/installer create manifests --log-level=debug
./ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml:1136: openshift-install --dir=/tmp/artifacts/installer create manifests
./ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml:1163: openshift-install --dir=/tmp/artifacts/installer create manifests
./ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml:1221: openshift-install --dir=/tmp/artifacts/installer create manifests
./ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml:1267: openshift-install --dir=/tmp/artifacts/installer create manifests
./ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml:770: openshift-install --dir=/tmp/artifacts/installer/ create manifests
./ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml:779: openshift-install --dir=/tmp/artifacts/installer/ create manifests
./ci-operator/templates/openshift/installer/cluster-launch-installer-src.yaml:555: openshift-install --dir=/tmp/artifacts/installer/ create manifests
./ci-operator/templates/openshift/installer/cluster-launch-installer-metal-e2e.yaml:402: openshift-install --dir=/tmp/artifacts/installer/ create manifests
./ci-operator/templates/openshift/installer/cluster-launch-installer-custom-test-image.yaml:644: openshift-install --dir=/tmp/artifacts/installer/ create manifests
./ci-operator/templates/openshift/installer/cluster-launch-installer-openstack-e2e.yaml:385: TF_LOG=debug openshift-install --dir=/tmp/artifacts/installer create manifests --log-level=debug
./ci-operator/templates/openshift/installer/cluster-launch-installer-upi-src.yaml:417: openshift-install --dir=/tmp/artifacts/installer create manifests
./ci-operator/templates/openshift/installer/cluster-launch-installer-upi-src.yaml:442: openshift-install --dir=/tmp/artifacts/installer create manifests
./ci-operator/templates/openshift/installer/cluster-launch-installer-upi-src.yaml:501: openshift-install --dir=/tmp/artifacts/installer create manifests
./ci-operator/templates/openshift/installer/cluster-launch-installer-remote-libvirt-e2e.yaml:518: mock-nss.sh openshift-install create manifests --dir=/tmp/artifacts/installer
./ci-operator/step-registry/ipi/install/install/ipi-install-install-commands.sh:39:TF_LOG=debug openshift-install --dir="${dir}" create manifests
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: staebler, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@wking: Updated the following 2 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No Terraform involved in creating manifests. Cleans up after d11bca7 (#8075). Also removes trailing whitespace from the YAML documentation.
Also backgrounds the
create manifestscall and immediately waits for it, so we can gracefully handle TERM as described in 4472ace (#2680).